Merged
Conversation
humphrey-xmos
force-pushed
the
feature/dfu-example
branch
from
849e56b to
76848c8
Compare
humphrey-xmos
force-pushed
the
feature/dfu-example
branch
6 times, most recently
from
0022678 to
8127e2f
Compare
Replacing word buffers for byte buffers
humphrey-xmos
force-pushed
the
feature/dfu-example
branch
from
3733113 to
a7c49d6
Compare
xross
reviewed
Mar 18, 2026
xross
reviewed
Mar 18, 2026
xross
approved these changes
Mar 18, 2026
Collaborator
xross
left a comment
xross
left a comment
There was a problem hiding this comment.
I think this looks okay to me, unsure why the previous buffers were ints.
Contributor
Author
I beleive becuase it originally wsa very close the USB functions that required int buffers. And they permiated across to these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updaintg XUA compatibility for changes while adding lib_dfu example